happyDomain/internal/api/controller/authentication.go
Pierre-Olivier Mercier b0b79efceb security: decouple failure tracking from captcha provider
Previously, RecordFailure/RecordSuccess were only called when a captcha
provider was configured, making brute-force tracking entirely inactive
on deployments without one.

- Always track login failures and successes regardless of captcha config
- When threshold is crossed with a captcha provider: 401 + captcha_required (existing behaviour)
- When threshold is crossed without a captcha provider: 429 + rate_limited flag
- Frontend: show a rate-limited message and disable the submit button on 429
- Add errors.rate-limited translation key to all locales

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-12 15:03:49 +07:00

174 lines
5.7 KiB
Go

// This file is part of the happyDomain (R) project.
// Copyright (c) 2020-2024 happyDomain
// Authors: Pierre-Olivier Mercier, et al.
//
// This program is offered under a commercial and under the AGPL license.
// For commercial licensing, contact us at <contact@happydomain.org>.
//
// For AGPL licensing:
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
package controller
import (
"fmt"
"log"
"net/http"
"github.com/gin-contrib/sessions"
"github.com/gin-gonic/gin"
"git.happydns.org/happyDomain/internal/api/middleware"
"git.happydns.org/happyDomain/model"
)
type LoginController struct {
authService happydns.AuthenticationUsecase
captcha happydns.CaptchaVerifier
failureTracker happydns.FailureTracker
}
func NewLoginController(authService happydns.AuthenticationUsecase, captchaVerifier happydns.CaptchaVerifier, failureTracker happydns.FailureTracker) *LoginController {
return &LoginController{
authService: authService,
captcha: captchaVerifier,
failureTracker: failureTracker,
}
}
// GetLoggedUser retrieves the currently logged-in user.
//
// @Summary Get the current user.
// @Schemes
// @Description Retrieve information about the currently logged-in user.
// @Tags authentication
// @Accept json
// @Produce json
// @Security securitydefinitions.basic
// @Success 200 {object} happydns.User
// @Failure 401 {object} happydns.ErrorResponse "Authentication failure"
// @Router /auth [get]
func (lc *LoginController) GetLoggedUser(c *gin.Context) {
c.JSON(http.StatusOK, c.MustGet("LoggedUser"))
}
// Login authenticates a user with username and password.
//
// @Summary Log in a user.
// @Schemes
// @Description Authenticate a user with email and password, creating a new session.
// @Tags authentication
// @Accept json
// @Produce json
// @Param body body happydns.LoginRequest true "Login credentials"
// @Success 200 {object} happydns.User
// @Failure 400 {object} happydns.ErrorResponse "Invalid input"
// @Failure 401 {object} happydns.ErrorResponse "Invalid username or password"
// @Router /auth [post]
func (lc *LoginController) Login(c *gin.Context) {
var request happydns.LoginRequest
err := c.ShouldBindJSON(&request)
if err != nil {
log.Printf("%s sends invalid LoginForm JSON: %s", c.ClientIP(), err.Error())
c.JSON(http.StatusBadRequest, happydns.ErrorResponse{Message: fmt.Sprintf("Something is wrong in received data: %s", err.Error())})
return
}
// Enforce captcha when a provider is configured and the failure threshold
// is reached. Failure tracking runs unconditionally so it stays effective
// even on deployments without a captcha provider.
if lc.failureTracker.RequiresCaptcha(c.ClientIP(), request.Email) {
if lc.captcha.Provider() != "" {
if request.CaptchaToken == "" {
c.JSON(http.StatusUnauthorized, happydns.LoginErrorResponse{
Message: "Captcha verification required.",
CaptchaRequired: true,
})
return
}
if err = lc.captcha.Verify(request.CaptchaToken, c.ClientIP()); err != nil {
log.Printf("%s: captcha verification failed: %s", c.ClientIP(), err.Error())
c.JSON(http.StatusUnauthorized, happydns.LoginErrorResponse{
Message: "Captcha verification failed.",
CaptchaRequired: true,
})
return
}
} else {
// No captcha provider — signal a plain rate-limit to the client.
c.JSON(http.StatusTooManyRequests, happydns.LoginErrorResponse{
Message: "Too many failed login attempts. Please wait before trying again.",
RateLimited: true,
})
return
}
}
user, err := lc.authService.AuthenticateUserWithPassword(request)
if err != nil {
log.Printf("%s %s: %s", c.ClientIP(), request.Email, err.Error())
lc.failureTracker.RecordFailure(c.ClientIP(), request.Email)
if lc.failureTracker.RequiresCaptcha(c.ClientIP(), request.Email) {
if lc.captcha.Provider() != "" {
c.JSON(http.StatusUnauthorized, happydns.LoginErrorResponse{
Message: "Invalid username or password.",
CaptchaRequired: true,
})
} else {
c.JSON(http.StatusTooManyRequests, happydns.LoginErrorResponse{
Message: "Too many failed login attempts. Please wait before trying again.",
RateLimited: true,
})
}
return
}
c.JSON(http.StatusUnauthorized, happydns.LoginErrorResponse{Message: "Invalid username or password."})
return
}
lc.failureTracker.RecordSuccess(c.ClientIP(), request.Email)
middleware.SessionLoginOK(c, user)
c.JSON(http.StatusOK, user)
}
// Logout clears the current user's session.
//
// @Summary Log out the current user.
// @Schemes
// @Description Clear the current user's session and log them out.
// @Tags authentication
// @Accept json
// @Produce json
// @Security securitydefinitions.basic
// @Success 204 "Session cleared"
// @Failure 500 {object} happydns.ErrorResponse
// @Router /auth/logout [post]
func (lc *LoginController) Logout(c *gin.Context) {
session := sessions.Default(c)
session.Clear()
err := session.Save()
if err != nil {
c.AbortWithStatusJSON(http.StatusInternalServerError, happydns.ErrorResponse{Message: err.Error()})
return
}
c.Status(http.StatusNoContent)
}