Use pointer receiver more offen
This commit is contained in:
parent
6999b4e728
commit
c7569b5e54
59 changed files with 688 additions and 672 deletions
|
@ -106,7 +106,7 @@ func searchBinaryInGit(edir string) (ret []string) {
|
|||
return
|
||||
}
|
||||
|
||||
func checkExercice(theme fic.Theme, edir string, dmap *map[int64]fic.Exercice) (errs []string) {
|
||||
func checkExercice(theme *fic.Theme, edir string, dmap *map[int64]*fic.Exercice) (errs []string) {
|
||||
e, _, eid, _, berrs := sync.BuildExercice(sync.GlobalImporter, theme, path.Join(theme.Path, edir), dmap)
|
||||
errs = append(errs, berrs...)
|
||||
|
||||
|
@ -115,26 +115,26 @@ func checkExercice(theme fic.Theme, edir string, dmap *map[int64]fic.Exercice) (
|
|||
var files []string
|
||||
var cerrs []string
|
||||
if !skipFileChecks {
|
||||
files, cerrs = sync.CheckExerciceFiles(sync.GlobalImporter, *e)
|
||||
files, cerrs = sync.CheckExerciceFiles(sync.GlobalImporter, e)
|
||||
log.Printf("%d files checked.\n", len(files))
|
||||
} else {
|
||||
files, cerrs = sync.CheckExerciceFilesPresence(sync.GlobalImporter, *e)
|
||||
files, cerrs = sync.CheckExerciceFilesPresence(sync.GlobalImporter, e)
|
||||
log.Printf("%d files presents but not checked (please check digest yourself).\n", len(files))
|
||||
}
|
||||
errs = append(errs, cerrs...)
|
||||
|
||||
// Flags
|
||||
flags, cerrs := sync.CheckExerciceFlags(sync.GlobalImporter, *e, files)
|
||||
flags, cerrs := sync.CheckExerciceFlags(sync.GlobalImporter, e, files)
|
||||
errs = append(errs, cerrs...)
|
||||
log.Printf("%d flags checked.\n", len(flags))
|
||||
|
||||
// Hints
|
||||
hints, cerrs := sync.CheckExerciceHints(sync.GlobalImporter, *e)
|
||||
hints, cerrs := sync.CheckExerciceHints(sync.GlobalImporter, e)
|
||||
errs = append(errs, cerrs...)
|
||||
log.Printf("%d hints checked.\n", len(hints))
|
||||
|
||||
if dmap != nil {
|
||||
(*dmap)[int64(eid)] = *e
|
||||
(*dmap)[int64(eid)] = e
|
||||
}
|
||||
}
|
||||
return
|
||||
|
@ -236,17 +236,17 @@ func main() {
|
|||
log.Println(err)
|
||||
}
|
||||
|
||||
exercices, err := sync.GetExercices(sync.GlobalImporter, *theme)
|
||||
exercices, err := sync.GetExercices(sync.GlobalImporter, theme)
|
||||
if err != nil {
|
||||
nberr += 1
|
||||
log.Println(err)
|
||||
continue
|
||||
}
|
||||
|
||||
dmap := map[int64]fic.Exercice{}
|
||||
dmap := map[int64]*fic.Exercice{}
|
||||
|
||||
for _, edir := range exercices {
|
||||
for _, err := range checkExercice(*theme, edir, &dmap) {
|
||||
for _, err := range checkExercice(theme, edir, &dmap) {
|
||||
nberr += 1
|
||||
log.Println(err)
|
||||
}
|
||||
|
@ -267,7 +267,7 @@ func main() {
|
|||
} else {
|
||||
log.Printf("This is not a theme directory, run checks for exercice.\n\n")
|
||||
|
||||
for _, err := range checkExercice(fic.Theme{}, p, &map[int64]fic.Exercice{}) {
|
||||
for _, err := range checkExercice(&fic.Theme{}, p, &map[int64]*fic.Exercice{}) {
|
||||
nberr += 1
|
||||
log.Println(err)
|
||||
}
|
||||
|
|
Reference in a new issue