Use pointer receiver more offen

This commit is contained in:
nemunaire 2021-11-22 15:35:07 +01:00
commit c7569b5e54
59 changed files with 688 additions and 672 deletions

View file

@ -19,13 +19,14 @@ type QAQuery struct {
}
// GetQAQuery retrieves the query with the given identifier.
func GetQAQuery(id int64) (q QAQuery, err error) {
func GetQAQuery(id int64) (q *QAQuery, err error) {
q = &QAQuery{}
err = DBQueryRow("SELECT id_qa, id_exercice, id_team, authuser, creation, state, subject, solved, closed FROM exercices_qa WHERE id_qa = ?", id).Scan(&q.Id, &q.IdExercice, &q.IdTeam, &q.User, &q.Creation, &q.State, &q.Subject, &q.Solved, &q.Closed)
return
}
// GetQAQueries returns a list of all QAQuery registered in the database.
func GetQAQueries() (res []QAQuery, err error) {
func GetQAQueries() (res []*QAQuery, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_qa, id_exercice, id_team, authuser, creation, state, subject, solved, closed FROM exercices_qa"); err != nil {
return
@ -33,7 +34,7 @@ func GetQAQueries() (res []QAQuery, err error) {
defer rows.Close()
for rows.Next() {
var q QAQuery
q := &QAQuery{}
if err = rows.Scan(&q.Id, &q.IdExercice, &q.IdTeam, &q.User, &q.Creation, &q.State, &q.Subject, &q.Solved, &q.Closed); err != nil {
return
}
@ -45,7 +46,7 @@ func GetQAQueries() (res []QAQuery, err error) {
}
// GetQAQueries returns a list of all QAQuery registered for the Exercice.
func (e Exercice) GetQAQueries() (res []QAQuery, err error) {
func (e *Exercice) GetQAQueries() (res []*QAQuery, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_qa, id_exercice, id_team, authuser, creation, state, subject, solved, closed FROM exercices_qa WHERE id_exercice = ?", e.Id); err != nil {
return nil, err
@ -53,7 +54,7 @@ func (e Exercice) GetQAQueries() (res []QAQuery, err error) {
defer rows.Close()
for rows.Next() {
var q QAQuery
q := &QAQuery{}
if err = rows.Scan(&q.Id, &q.IdExercice, &q.IdTeam, &q.User, &q.Creation, &q.State, &q.Subject, &q.Solved, &q.Closed); err != nil {
return
}
@ -65,7 +66,7 @@ func (e Exercice) GetQAQueries() (res []QAQuery, err error) {
}
// GetQAQueries returns a list of all QAQuery registered for the Exercice.
func (t Team) GetQAQueries() (res []QAQuery, err error) {
func (t *Team) GetQAQueries() (res []*QAQuery, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_qa, id_exercice, id_team, authuser, creation, state, subject, solved, closed FROM exercices_qa WHERE id_team = ?", t.Id); err != nil {
return nil, err
@ -73,7 +74,7 @@ func (t Team) GetQAQueries() (res []QAQuery, err error) {
defer rows.Close()
for rows.Next() {
var q QAQuery
q := &QAQuery{}
if err = rows.Scan(&q.Id, &q.IdExercice, &q.IdTeam, &q.User, &q.Creation, &q.State, &q.Subject, &q.Solved, &q.Closed); err != nil {
return
}
@ -85,24 +86,25 @@ func (t Team) GetQAQueries() (res []QAQuery, err error) {
}
// GetQAQuery retrieves the query with the given identifier.
func (e Exercice) GetQAQuery(id int64) (q QAQuery, err error) {
func (e *Exercice) GetQAQuery(id int64) (q *QAQuery, err error) {
q = &QAQuery{}
err = DBQueryRow("SELECT id_qa, id_exercice, id_team, authuser, creation, state, subject, solved, closed FROM exercices_qa WHERE id_qa = ? AND id_exercice = ?", id, e.Id).Scan(&q.Id, &q.IdExercice, &q.IdTeam, &q.User, &q.Creation, &q.State, &q.Subject, &q.Solved, &q.Closed)
return
}
// NewQAQuery creates and fills a new struct QAQuery and registers it into the database.
func (e Exercice) NewQAQuery(subject string, teamId *int64, user string, state string) (QAQuery, error) {
func (e *Exercice) NewQAQuery(subject string, teamId *int64, user string, state string) (*QAQuery, error) {
if res, err := DBExec("INSERT INTO exercices_qa (id_exercice, id_team, authuser, creation, state, subject) VALUES (?, ?, ?, ?, ?, ?)", e.Id, teamId, user, time.Now(), state, subject); err != nil {
return QAQuery{}, err
return nil, err
} else if qid, err := res.LastInsertId(); err != nil {
return QAQuery{}, err
return nil, err
} else {
return QAQuery{qid, e.Id, teamId, user, time.Now(), state, subject, nil, nil}, nil
return &QAQuery{qid, e.Id, teamId, user, time.Now(), state, subject, nil, nil}, nil
}
}
// Update applies modifications back to the database.
func (q QAQuery) Update() (int64, error) {
func (q *QAQuery) Update() (int64, error) {
if res, err := DBExec("UPDATE exercices_qa SET subject = ?, id_team = ?, authuser = ?, id_exercice = ?, creation = ?, state = ?, solved = ?, closed = ? WHERE id_qa = ?", q.Subject, q.IdTeam, q.User, q.IdExercice, q.Creation, q.State, q.Solved, q.Closed, q.Id); err != nil {
return 0, err
} else if nb, err := res.RowsAffected(); err != nil {
@ -113,7 +115,7 @@ func (q QAQuery) Update() (int64, error) {
}
// Delete the query from the database.
func (q QAQuery) Delete() (int64, error) {
func (q *QAQuery) Delete() (int64, error) {
if _, err := DBExec("DELETE FROM qa_comments WHERE id_qa = ?", q.Id); err != nil {
return 0, err
} else if res, err := DBExec("DELETE FROM exercices_qa WHERE id_qa = ?", q.Id); err != nil {
@ -146,7 +148,7 @@ type QAComment struct {
}
// GetComments returns a list of all descriptions stored in the database for the QAQuery.
func (q QAQuery) GetComments() (res []QAComment, err error) {
func (q *QAQuery) GetComments() (res []*QAComment, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_comment, id_team, authuser, date, content FROM qa_comments WHERE id_qa = ?", q.Id); err != nil {
return nil, err
@ -154,7 +156,7 @@ func (q QAQuery) GetComments() (res []QAComment, err error) {
defer rows.Close()
for rows.Next() {
var c QAComment
c := &QAComment{}
if err = rows.Scan(&c.Id, &c.IdTeam, &c.User, &c.Date, &c.Content); err != nil {
return
}
@ -166,24 +168,25 @@ func (q QAQuery) GetComments() (res []QAComment, err error) {
}
// GetComment returns the comment stored in the database for the QAQuery.
func (q QAQuery) GetComment(id int64) (c QAComment, err error) {
func (q *QAQuery) GetComment(id int64) (c *QAComment, err error) {
c = &QAComment{}
err = DBQueryRow("SELECT id_comment, id_team, authuser, date, content FROM qa_comments WHERE id_comment = ? AND id_qa = ?", id, q.Id).Scan(&c.Id, &c.IdTeam, &c.User, &c.Date, &c.Content)
return
}
// AddComment append in the database a new description; then returns the corresponding structure.
func (q QAQuery) AddComment(content string, teamId *int64, user string) (QAComment, error) {
func (q *QAQuery) AddComment(content string, teamId *int64, user string) (*QAComment, error) {
if res, err := DBExec("INSERT INTO qa_comments (id_qa, id_team, authuser, date, content) VALUES (?, ?, ?, ?, ?)", q.Id, teamId, user, time.Now(), content); err != nil {
return QAComment{}, err
return nil, err
} else if cid, err := res.LastInsertId(); err != nil {
return QAComment{}, err
return nil, err
} else {
return QAComment{cid, teamId, user, time.Now(), content}, nil
return &QAComment{cid, teamId, user, time.Now(), content}, nil
}
}
// Update applies modifications back to the database
func (c QAComment) Update() (int64, error) {
func (c *QAComment) Update() (int64, error) {
if res, err := DBExec("UPDATE qa_comments SET id_team = ?, authuser = ?, date = ?, content = ? WHERE id_comment = ?", c.IdTeam, c.User, c.Date, c.Content, c.Id); err != nil {
return 0, err
} else if nb, err := res.RowsAffected(); err != nil {
@ -194,7 +197,7 @@ func (c QAComment) Update() (int64, error) {
}
// Delete the comment in the database.
func (c QAComment) Delete() (int64, error) {
func (c *QAComment) Delete() (int64, error) {
if res, err := DBExec("DELETE FROM qa_comments WHERE id_comment = ?", c.Id); err != nil {
return 0, err
} else if nb, err := res.RowsAffected(); err != nil {
@ -210,7 +213,7 @@ type QATodo struct {
IdExercice int64 `json:"id_exercice"`
}
func (t Team) GetQATodo() (res []QATodo, err error) {
func (t *Team) GetQATodo() (res []*QATodo, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_todo, id_exercice FROM teams_qa_todo WHERE id_team = ?", t.Id); err != nil {
return nil, err
@ -218,7 +221,7 @@ func (t Team) GetQATodo() (res []QATodo, err error) {
defer rows.Close()
for rows.Next() {
var t QATodo
t := &QATodo{}
if err = rows.Scan(&t.Id, &t.IdExercice); err != nil {
return
}
@ -229,19 +232,19 @@ func (t Team) GetQATodo() (res []QATodo, err error) {
return
}
func (t Team) NewQATodo(idExercice int64) (QATodo, error) {
func (t *Team) NewQATodo(idExercice int64) (*QATodo, error) {
if res, err := DBExec("INSERT INTO teams_qa_todo (id_team, id_exercice) VALUES (?, ?)", t.Id, idExercice); err != nil {
return QATodo{}, err
return nil, err
} else if tid, err := res.LastInsertId(); err != nil {
return QATodo{}, err
return nil, err
} else {
return QATodo{tid, t.Id, idExercice}, nil
return &QATodo{tid, t.Id, idExercice}, nil
}
}
// QAView
func (t Team) GetQAView() (res []QATodo, err error) {
func (t *Team) GetQAView() (res []*QATodo, err error) {
var rows *sql.Rows
if rows, err = DBQuery("SELECT id_view, id_exercice FROM teams_qa_view WHERE id_team = ?", t.Id); err != nil {
return nil, err
@ -249,7 +252,7 @@ func (t Team) GetQAView() (res []QATodo, err error) {
defer rows.Close()
for rows.Next() {
var t QATodo
t := &QATodo{}
if err = rows.Scan(&t.Id, &t.IdExercice); err != nil {
return
}
@ -260,12 +263,12 @@ func (t Team) GetQAView() (res []QATodo, err error) {
return
}
func (t Team) NewQAView(idExercice int64) (QATodo, error) {
func (t *Team) NewQAView(idExercice int64) (*QATodo, error) {
if res, err := DBExec("INSERT INTO teams_qa_view (id_team, id_exercice) VALUES (?, ?)", t.Id, idExercice); err != nil {
return QATodo{}, err
return nil, err
} else if tid, err := res.LastInsertId(); err != nil {
return QATodo{}, err
return nil, err
} else {
return QATodo{tid, t.Id, idExercice}, nil
return &QATodo{tid, t.Id, idExercice}, nil
}
}