fic/server
Archived
1
0
Fork 0
Code Issues Pull requests 10 Releases Wiki Activity

repochecker: Ensure non-optional flag doesn't depend on optional one

Browse source
This commit is contained in:
nemunaire 2024-03-17 17:58:11 +01:00
parent b3c207d07d
commit 09c1111135
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
admin/sync/exercice_keys.go
View file

@ -555,6 +555,15 @@ func CheckExerciceFlags(i Importer, exercice *fic.Exercice, files []string, exce
} }
} }
// Check dependency to flag optional flag
if fk, ok := flag.Flag.(*fic.FlagKey); ok && fk.BonusGain == 0 {
for _, nf := range flag.FlagsDeps {
if fk2, ok := flags[nf].Flag.(*fic.FlagKey); ok && fk2.BonusGain != 0 {
errs = multierr.Append(errs, NewFlagError(exercice, nil, flag.Line, fmt.Errorf("flag is not optional but depend on flag id=%d which is optional", nf)))
}
}
}
// Check dependency loop // Check dependency loop
deps := flag.FlagsDeps deps := flag.FlagsDeps
for i := 0; i < len(deps); i++ { for i := 0; i < len(deps); i++ {