Xmlparser module: getNodes is now a generator

modules/books.py

@@ -66,8 +66,7 @@ def cmd_books(msg):
     res = Response(channel=msg.channel,
                    title="%s" % (title), count=" (%d more books)")
 
-    books = search_books(title)
-    for book in books:
+    for book in search_books(title):
         res.append_message("%s, writed by %s" % (book.getNode("best_book").getNode("title").getContent(), book.getNode("best_book").getNode("author").getNode("name").getContent()))
     return res
 

xmlparser/node.py

@@ -152,15 +152,12 @@ class ModuleState:
 
   def getNodes(self, tagname):
     """Get all direct childs that have the given tagname"""
-    ret = list()
     for child in self.childs:
       if tagname is None or tagname == child.name:
-        ret.append(child)
-    return ret
+        yield child
 
   def hasNode(self, tagname):
     """Return True if at least one node with the given tagname exists"""
-    ret = list()
     for child in self.childs:
       if tagname is None or tagname == child.name:
         return True