eiwd/src/e_mod_popup.c
Pierre-Olivier Mercier 0ab9561d2b security: wipe passphrases, bind hidden stash to SSID, re-register agent
Wipe passphrase memory in the auth and hidden-network dialogs (explicit_bzero
on owned copies plus overwriting the elm_entry buffer before destruction) so
secrets don't linger on the heap. Bind the hidden-network passphrase stash to
its SSID with a 30s timeout, so a typo'd or out-of-range hidden connect can't
leak its passphrase to an unrelated network whose RequestPassphrase happens
to land first. Re-RegisterAgent on iwd NameOwnerChanged so PSK connects
survive systemctl restart iwd instead of silently hanging.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-29 11:24:45 +07:00

490 lines
15 KiB
C

#include "e_mod_main.h"
#include "e_mod_popup.h"
#include "iwd/iwd_manager.h"
#include "iwd/iwd_device.h"
#include "iwd/iwd_network.h"
#include "iwd/iwd_agent.h"
#include "ui/wifi_auth.h"
#include "ui/wifi_hidden.h"
#include <e_gadcon_popup.h>
#include <stdlib.h>
#include <string.h>
typedef struct _Popup
{
E_Gadcon_Popup *gp;
Evas_Object *box;
Evas_Object *status_lbl;
Evas_Object *list;
Evas_Object *btn_scan;
Evas_Object *btn_toggle;
Evas_Object *btn_hidden;
Evas_Object *btn_disconnect; /* shown only when connected */
Evas_Object *action_row;
Eina_Bool listening;
} Popup;
static Popup *_popup = NULL;
/* Pending passphrase request from the agent — only one at a time. */
static Iwd_Agent_Request *_pending_req = NULL;
/* Tracked so iwd's Cancel(reason) can tear down the dialog. */
static Evas_Object *_pending_dialog = NULL;
/* One-shot passphrase pre-armed by the hidden-network dialog. Bound to the
* SSID it was entered for, with a timeout that wipes it if iwd never comes
* asking — so a stashed passphrase can never leak to an unrelated network. */
static char *_hidden_pending_pass = NULL;
static char *_hidden_pending_ssid = NULL;
static Ecore_Timer *_hidden_pending_timer = NULL;
#define HIDDEN_PASS_TIMEOUT 30.0 /* seconds */
static void
_hidden_pending_clear(void)
{
if (_hidden_pending_pass)
{
explicit_bzero(_hidden_pending_pass, strlen(_hidden_pending_pass));
free(_hidden_pending_pass);
_hidden_pending_pass = NULL;
}
free(_hidden_pending_ssid);
_hidden_pending_ssid = NULL;
if (_hidden_pending_timer)
{
ecore_timer_del(_hidden_pending_timer);
_hidden_pending_timer = NULL;
}
}
static Eina_Bool
_hidden_pending_timeout(void *data EINA_UNUSED)
{
_hidden_pending_timer = NULL;
_hidden_pending_clear();
return ECORE_CALLBACK_CANCEL;
}
/* ----- helpers --------------------------------------------------------- */
static const char *
_state_label(Iwd_State s)
{
switch (s) {
case IWD_STATE_OFF: return "Wi-Fi disabled";
case IWD_STATE_IDLE: return "Disconnected";
case IWD_STATE_SCANNING: return "Scanning…";
case IWD_STATE_CONNECTING: return "Connecting…";
case IWD_STATE_CONNECTED: return "Connected";
case IWD_STATE_ERROR: return "Error";
}
return "";
}
static const char *
_sec_label(Iwd_Security s)
{
switch (s) {
case IWD_SEC_OPEN: return "open";
case IWD_SEC_PSK: return "WPA";
case IWD_SEC_8021X: return "802.1X";
case IWD_SEC_WEP: return "WEP";
case IWD_SEC_UNKNOWN: return "?";
}
return "";
}
static int
_net_cmp(const void *a, const void *b)
{
const Iwd_Network *na = a, *nb = b;
if (na->connected != nb->connected) return nb->connected - na->connected;
if (na->known_path && !nb->known_path) return -1;
if (!na->known_path && nb->known_path) return 1;
/* Higher signal first within same class. */
int ta = iwd_network_signal_tier(na);
int tb = iwd_network_signal_tier(nb);
if (ta != tb) return tb - ta;
if (!na->ssid) return 1;
if (!nb->ssid) return -1;
return strcasecmp(na->ssid, nb->ssid);
}
static const char *
_signal_bars(int tier)
{
switch (tier)
{
case 4: return "▂▄▆█";
case 3: return "▂▄▆ ";
case 2: return "▂▄ ";
case 1: return "";
default: return " ";
}
}
/* First device that has a station; used for "Disconnect" and hidden connect. */
static Iwd_Device *
_active_device(void)
{
if (!e_iwd || !e_iwd->manager) return NULL;
const Eina_Hash *h = iwd_manager_devices(e_iwd->manager);
if (!h) return NULL;
Eina_Iterator *it = eina_hash_iterator_data_new((Eina_Hash *)h);
Iwd_Device *d, *best = NULL;
EINA_ITERATOR_FOREACH(it, d)
{
if (!d->has_station) continue;
if (!best) best = d;
if (d->connected_network) { best = d; break; }
}
eina_iterator_free(it);
return best;
}
/* ----- list rendering -------------------------------------------------- */
static void
_on_net_clicked(void *data, Evas_Object *obj EINA_UNUSED, void *ev EINA_UNUSED)
{
Iwd_Network *n = data;
if (!n) return;
iwd_network_connect(n);
}
static void
_on_net_forget(void *data, Evas_Object *obj EINA_UNUSED, void *ev EINA_UNUSED)
{
Iwd_Network *n = data;
if (!n) return;
iwd_network_forget(n);
}
static void
_rebuild_list(Popup *p)
{
if (!p->list || !e_iwd || !e_iwd->manager) return;
elm_box_clear(p->list);
/* When the radio is off, hide the (now-stale) network list entirely. */
if (iwd_manager_state(e_iwd->manager) == IWD_STATE_OFF) return;
const Eina_Hash *h = iwd_manager_networks(e_iwd->manager);
if (!h) return;
/* Snapshot into a list so we can sort. */
Eina_List *items = NULL;
Eina_Iterator *it = eina_hash_iterator_data_new((Eina_Hash *)h);
Iwd_Network *n;
EINA_ITERATOR_FOREACH(it, n) items = eina_list_append(items, n);
eina_iterator_free(it);
items = eina_list_sort(items, eina_list_count(items), _net_cmp);
Eina_List *l;
EINA_LIST_FOREACH(items, l, n)
{
Evas_Object *row = elm_box_add(p->list);
elm_box_horizontal_set(row, EINA_TRUE);
elm_box_padding_set(row, 4, 0);
evas_object_size_hint_weight_set(row, EVAS_HINT_EXPAND, 0);
evas_object_size_hint_align_set(row, EVAS_HINT_FILL, 0);
Evas_Object *btn = elm_button_add(row);
/* Truncate long SSIDs so the row never forces horizontal scrolling. */
const char *raw_ssid = n->ssid ? n->ssid : "(hidden)";
char ssid_buf[32];
const int max_ssid = 22;
if ((int)strlen(raw_ssid) > max_ssid)
{
snprintf(ssid_buf, sizeof(ssid_buf), "%.*s…", max_ssid - 1, raw_ssid);
raw_ssid = ssid_buf;
}
char label[256];
snprintf(label, sizeof(label), "%s %s%s [%s]%s",
_signal_bars(iwd_network_signal_tier(n)),
n->known_path ? "" : " ",
raw_ssid,
_sec_label(n->security),
n->connected ? "" : "");
elm_object_text_set(btn, label);
evas_object_size_hint_weight_set(btn, EVAS_HINT_EXPAND, 0);
evas_object_size_hint_align_set(btn, EVAS_HINT_FILL, 0);
evas_object_smart_callback_add(btn, "clicked", _on_net_clicked, n);
elm_box_pack_end(row, btn);
evas_object_show(btn);
if (n->known_path)
{
Evas_Object *fb = elm_button_add(row);
elm_object_text_set(fb, "");
elm_object_tooltip_text_set(fb, "Forget network");
evas_object_smart_callback_add(fb, "clicked", _on_net_forget, n);
elm_box_pack_end(row, fb);
evas_object_show(fb);
}
elm_box_pack_end(p->list, row);
evas_object_show(row);
}
eina_list_free(items);
}
static void
_refresh(Popup *p)
{
if (!p || !e_iwd || !e_iwd->manager) return;
Iwd_State s = iwd_manager_state(e_iwd->manager);
if (p->status_lbl)
elm_object_text_set(p->status_lbl, _state_label(s));
if (p->btn_toggle)
elm_object_text_set(p->btn_toggle, s == IWD_STATE_OFF ? "Enable" : "Disable");
if (p->btn_scan)
elm_object_disabled_set(p->btn_scan, s == IWD_STATE_OFF);
if (p->btn_hidden)
elm_object_disabled_set(p->btn_hidden, s == IWD_STATE_OFF);
if (p->btn_disconnect)
{
Eina_Bool show = (s == IWD_STATE_CONNECTED);
if (show) evas_object_show(p->btn_disconnect);
else evas_object_hide(p->btn_disconnect);
}
_rebuild_list(p);
}
static void
_on_manager_change(void *data, Iwd_Manager *m EINA_UNUSED)
{
_refresh(data);
}
/* ----- action buttons -------------------------------------------------- */
static void _on_rescan (void *d EINA_UNUSED, Evas_Object *o EINA_UNUSED, void *e EINA_UNUSED)
{
if (e_iwd && e_iwd->manager) iwd_manager_scan_request(e_iwd->manager);
}
static void _on_toggle(void *d EINA_UNUSED, Evas_Object *o EINA_UNUSED, void *e EINA_UNUSED)
{
if (!e_iwd || !e_iwd->manager) return;
Eina_Bool off = (iwd_manager_state(e_iwd->manager) == IWD_STATE_OFF);
iwd_manager_set_powered(e_iwd->manager, off);
}
static void _on_disconnect(void *d EINA_UNUSED, Evas_Object *o EINA_UNUSED, void *e EINA_UNUSED)
{
Iwd_Device *dev = _active_device();
if (dev) iwd_device_disconnect(dev);
}
static void
_on_hidden_done(void *data EINA_UNUSED, const char *ssid, const char *pass, Eina_Bool ok)
{
if (!ok || !ssid || !*ssid) return;
Iwd_Device *dev = _active_device();
if (!dev) return;
/* Pre-arm the agent reply so the next RequestPassphrase from iwd for
* *this SSID* is answered automatically. The stash is bound to the SSID
* and self-clears after HIDDEN_PASS_TIMEOUT seconds — so a typo'd or
* out-of-range SSID cannot cause the passphrase to leak to a later,
* unrelated network whose RequestPassphrase happens to land first. */
_hidden_pending_clear();
if (pass && *pass)
{
_hidden_pending_pass = strdup(pass);
_hidden_pending_ssid = strdup(ssid);
_hidden_pending_timer = ecore_timer_add(HIDDEN_PASS_TIMEOUT,
_hidden_pending_timeout, NULL);
}
iwd_device_connect_hidden(dev, ssid);
}
static void _on_hidden(void *d EINA_UNUSED, Evas_Object *o EINA_UNUSED, void *e EINA_UNUSED)
{
wifi_hidden_prompt(_popup ? _popup->box : e_comp->elm, _on_hidden_done, NULL);
}
/* ----- passphrase plumbing -------------------------------------------- */
static void
_on_auth_done(void *data EINA_UNUSED, const char *pass, Eina_Bool ok)
{
_pending_dialog = NULL;
if (!_pending_req)
{
/* Request was already canceled by iwd; nothing to do. The caller
* (wifi_auth) wipes its own copy of `pass` after we return. */
return;
}
if (ok) iwd_agent_reply (_pending_req, pass ? pass : "");
else iwd_agent_cancel(_pending_req);
_pending_req = NULL;
}
static void
_on_agent_cancel(void *data EINA_UNUSED, const char *reason EINA_UNUSED)
{
/* iwd dropped the auth attempt — close any open dialog. The dialog's
* DEL handler will fire _on_auth_done(ok=FALSE), but _pending_req has
* already been consumed by iwd, so clear it first to avoid double-cancel. */
_pending_req = NULL;
if (_pending_dialog)
{
Evas_Object *d = _pending_dialog;
_pending_dialog = NULL;
evas_object_del(d);
}
}
static void _on_passphrase_request(void *data, Iwd_Agent_Request *req, const char *netpath);
void
e_iwd_popup_install_passphrase_handler(void)
{
if (e_iwd && e_iwd->manager)
{
iwd_manager_set_passphrase_handler(e_iwd->manager, _on_passphrase_request, NULL);
iwd_manager_set_cancel_handler (e_iwd->manager, _on_agent_cancel, NULL);
}
}
static void
_on_passphrase_request(void *data EINA_UNUSED, Iwd_Agent_Request *req, const char *netpath)
{
/* Resolve netpath -> network so we can both match the hidden stash
* against the requested SSID *and* show a friendly label in the dialog. */
Iwd_Network *n = NULL;
if (e_iwd && e_iwd->manager)
{
const Eina_Hash *h = iwd_manager_networks(e_iwd->manager);
if (h) n = eina_hash_find(h, netpath);
}
const char *req_ssid = (n && n->ssid) ? n->ssid : NULL;
/* Use the hidden-network stash *only* if iwd is asking for the same
* SSID we entered it for. Anything else: drop the stash on the floor
* and prompt normally. */
if (_hidden_pending_pass && _hidden_pending_ssid &&
req_ssid && !strcmp(req_ssid, _hidden_pending_ssid))
{
iwd_agent_reply(req, _hidden_pending_pass);
_hidden_pending_clear();
return;
}
if (_pending_req)
{
iwd_agent_cancel(req);
return;
}
_pending_req = req;
const char *ssid = req_ssid ? req_ssid : "network";
const char *sec = n ? _sec_label(n->security) : NULL;
_pending_dialog = wifi_auth_prompt(_popup ? _popup->box : e_comp->elm,
ssid, sec, _on_auth_done, NULL);
}
/* ----- popup lifecycle ------------------------------------------------- */
static void
_destroy(void)
{
if (!_popup) return;
if (_popup->listening && e_iwd && e_iwd->manager)
iwd_manager_listener_del(e_iwd->manager, _on_manager_change, _popup);
if (_popup->gp) e_object_del(E_OBJECT(_popup->gp));
free(_popup);
_popup = NULL;
}
void
e_iwd_popup_shutdown(void)
{
_destroy();
_hidden_pending_clear();
}
void
e_iwd_popup_close(void) { _destroy(); }
void
e_iwd_popup_refresh(void) { if (_popup) _refresh(_popup); }
void
e_iwd_popup_toggle(E_Gadcon_Client *gcc)
{
if (_popup) { _destroy(); return; }
if (!gcc || !e_iwd) return;
Popup *p = calloc(1, sizeof(*p));
_popup = p;
p->gp = e_gadcon_popup_new(gcc, EINA_FALSE);
Evas *evas = evas_object_evas_get(gcc->o_base);
Evas_Object *box = elm_box_add(e_comp->elm);
(void)evas;
elm_box_padding_set(box, 0, 4);
evas_object_size_hint_min_set(box, 240, 320);
p->box = box;
/* Status line */
Evas_Object *st = elm_label_add(box);
p->status_lbl = st;
elm_box_pack_end(box, st);
evas_object_show(st);
/* Network list (vertical box of buttons — keeps deps minimal) */
Evas_Object *scroller = elm_scroller_add(box);
evas_object_size_hint_weight_set(scroller, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(scroller, EVAS_HINT_FILL, EVAS_HINT_FILL);
Evas_Object *list_box = elm_box_add(scroller);
evas_object_size_hint_weight_set(list_box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(list_box, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_object_content_set(scroller, list_box);
evas_object_show(list_box);
elm_box_pack_end(box, scroller);
evas_object_show(scroller);
p->list = list_box;
/* Action row */
Evas_Object *row = elm_box_add(box);
elm_box_horizontal_set(row, EINA_TRUE);
elm_box_padding_set(row, 4, 0);
p->action_row = row;
p->btn_scan = elm_button_add(row);
elm_object_text_set(p->btn_scan, "Rescan");
evas_object_smart_callback_add(p->btn_scan, "clicked", _on_rescan, NULL);
elm_box_pack_end(row, p->btn_scan); evas_object_show(p->btn_scan);
p->btn_toggle = elm_button_add(row);
elm_object_text_set(p->btn_toggle, "Disable");
evas_object_smart_callback_add(p->btn_toggle, "clicked", _on_toggle, NULL);
elm_box_pack_end(row, p->btn_toggle); evas_object_show(p->btn_toggle);
p->btn_hidden = elm_button_add(row);
elm_object_text_set(p->btn_hidden, "Hidden…");
evas_object_smart_callback_add(p->btn_hidden, "clicked", _on_hidden, NULL);
elm_box_pack_end(row, p->btn_hidden); evas_object_show(p->btn_hidden);
p->btn_disconnect = elm_button_add(row);
elm_object_text_set(p->btn_disconnect, "Disconnect");
evas_object_smart_callback_add(p->btn_disconnect, "clicked", _on_disconnect, NULL);
elm_box_pack_end(row, p->btn_disconnect);
/* Visibility is driven by _refresh() based on connection state. */
elm_box_pack_end(box, row);
evas_object_show(row);
evas_object_show(box);
e_gadcon_popup_content_set(p->gp, box);
e_gadcon_popup_show(p->gp);
if (e_iwd->manager)
{
iwd_manager_listener_add(e_iwd->manager, _on_manager_change, p);
p->listening = EINA_TRUE;
iwd_manager_set_passphrase_handler(e_iwd->manager, _on_passphrase_request, NULL);
iwd_manager_scan_request(e_iwd->manager);
}
_refresh(p);
}