nemunaire/eiwd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gadget: stringshare gadcon id instead of static buffer

Browse source 
A static char[128] returned from _gc_id_new is overwritten on every
call, so multiple gadget instances would alias the same id once gadcon
compares or stores it. eina_stringshare_add gives each instance its
own stable id.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
nemunaire 2026-04-29 11:25:56 +07:00
commit 47d70ab78d
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/e_mod_gadget.c
View file

@ -259,10 +259,10 @@ _gc_icon(const E_Gadcon_Client_Class *cc EINA_UNUSED, Evas *evas)
static const char * static const char *
_gc_id_new(const E_Gadcon_Client_Class *cc) _gc_id_new(const E_Gadcon_Client_Class *cc)
{ {
static char buf[128]; char buf[128];
snprintf(buf, sizeof(buf), "%s.%d", cc->name, snprintf(buf, sizeof(buf), "%s.%d", cc->name,
eina_list_count(_instances) + 1); eina_list_count(_instances) + 1);
return buf; return eina_stringshare_add(buf);
} }
static const E_Gadcon_Client_Class _gadcon_class = static const E_Gadcon_Client_Class _gadcon_class =