nemunaire/eiwd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

manager: surface D-Bus call errors to the user

Browse source 
Connect / Forget / Set(Powered) / Scan / Disconnect / RegisterAgent /
ConnectHidden previously discarded reply errors with NULL callbacks, so
"Connecting…" could hang forever after a refused call (rfkill, busy
adapter, another agent already registered, bad credentials on a known
network). The user had no way to see the failure.

Add iwd_manager_{report,last,clear}_error and wire reply callbacks in
adapter / device / network / agent. The popup status line now appends
the latest error to the state label, and user actions (rescan, toggle,
connect, disconnect) clear it.

Scan errors that mean "already in flight" are filtered out — they're
the normal race when two scan triggers fire close together.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
nemunaire 2026-04-29 11:29:59 +07:00
commit 0418e8bab9
7 changed files with 165 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/iwd/iwd_manager.c
View file

@ -4,6 +4,8 @@
#include "iwd_device.h"
#include "iwd_network.h"
#include <Ecore.h>
#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@ -23,6 +25,7 @@ struct _Iwd_Manager
Eina_List *listeners; /* Listener * */
Iwd_State state;
Ecore_Job *notify_job;
char *last_error;
Iwd_Agent_Passphrase_Cb pass_cb;
void *pass_data;
@ -102,6 +105,33 @@ iwd_manager_notify(Iwd_Manager *m)
m->notify_job = ecore_job_add(_notify_job_cb, m);
}
const char *
iwd_manager_last_error(const Iwd_Manager *m) { return m ? m->last_error : NULL; }
void
iwd_manager_clear_error(Iwd_Manager *m)
{
if (!m || !m->last_error) return;
free(m->last_error);
m->last_error = NULL;
}
void
iwd_manager_report_error(Iwd_Manager *m, const char *fmt, ...)
{
if (!m || !fmt) return;
char buf[256];
va_list ap;
va_start(ap, fmt);
vsnprintf(buf, sizeof(buf), fmt, ap);
va_end(ap);
/* stderr keeps the dev-visible trail; the stashed copy drives the UI. */
fprintf(stderr, "e_iwd: %s\n", buf);
free(m->last_error);
m->last_error = strdup(buf);
iwd_manager_notify(m);
}
/* ----- state aggregation ---------------------------------------------- */
static void
@ -281,6 +311,7 @@ iwd_manager_free(Iwd_Manager *m)
eina_hash_free(m->networks);
Listener *li;
EINA_LIST_FREE(m->listeners, li) free(li);
free(m->last_error);
free(m);
}