happyDomain/happyDeliver
2
0
Fork 0
Code Issues 8 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Handle RBL error report

Browse source
This commit is contained in:
nemunaire 2025-10-21 12:52:38 +07:00
commit 1be917136c
1 changed files with 40 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

43
pkg/analyzer/rbl.go
View file

@ -211,10 +211,19 @@ func (r *RBLChecker) checkIP(ip, rbl string) RBLCheck {
return check return check
} }
// If we got a response, the IP is listed // If we got a response, check the return code
if len(addrs) > 0 { if len(addrs) > 0 {
check.Listed = true
check.Response = addrs[0] // Return code (e.g., 127.0.0.2) check.Response = addrs[0] // Return code (e.g., 127.0.0.2)
// Check for RBL error codes: 127.255.255.253, 127.255.255.254, 127.255.255.255
// These indicate RBL operational issues, not actual listings
if addrs[0] == "127.255.255.253" || addrs[0] == "127.255.255.254" || addrs[0] == "127.255.255.255" {
check.Listed = false
check.Error = fmt.Sprintf("RBL %s returned error code %s (RBL operational issue)", rbl, addrs[0])
} else {
// Normal listing response
check.Listed = true
}
} }
return check return check
@ -275,11 +284,15 @@ func (r *RBLChecker) GenerateRBLChecks(results *RBLResults) []api.Check {
summaryCheck := r.generateSummaryCheck(results) summaryCheck := r.generateSummaryCheck(results)
checks = append(checks, summaryCheck) checks = append(checks, summaryCheck)
// Create individual checks for each listing // Create individual checks for each listing and RBL errors
for _, check := range results.Checks { for _, check := range results.Checks {
if check.Listed { if check.Listed {
detailCheck := r.generateListingCheck(&check) detailCheck := r.generateListingCheck(&check)
checks = append(checks, detailCheck) checks = append(checks, detailCheck)
} else if check.Error != "" && strings.Contains(check.Error, "RBL operational issue") {
// Generate info check for RBL errors
detailCheck := r.generateRBLErrorCheck(&check)
checks = append(checks, detailCheck)
} }
} }
@ -367,6 +380,30 @@ func (r *RBLChecker) generateListingCheck(rblCheck *RBLCheck) api.Check {
return check return check
} }
// generateRBLErrorCheck creates an info-level check for RBL operational errors
func (r *RBLChecker) generateRBLErrorCheck(rblCheck *RBLCheck) api.Check {
check := api.Check{
Category: api.Blacklist,
Name: fmt.Sprintf("RBL: %s", rblCheck.RBL),
Status: api.CheckStatusInfo,
Score: 0, // No penalty for RBL operational issues
Grade: ScoreToCheckGrade(-1),
Severity: api.PtrTo(api.CheckSeverityInfo),
}
check.Message = fmt.Sprintf("RBL %s returned an error code for IP %s", rblCheck.RBL, rblCheck.IP)
advice := fmt.Sprintf("The RBL %s is experiencing operational issues (error code: %s).", rblCheck.RBL, rblCheck.Response)
check.Advice = &advice
if rblCheck.Response != "" {
details := fmt.Sprintf("Error code: %s (RBL operational issue, not a listing)", rblCheck.Response)
check.Details = &details
}
return check
}
// GetUniqueListedIPs returns a list of unique IPs that are listed on at least one RBL // GetUniqueListedIPs returns a list of unique IPs that are listed on at least one RBL
func (r *RBLChecker) GetUniqueListedIPs(results *RBLResults) []string { func (r *RBLChecker) GetUniqueListedIPs(results *RBLResults) []string {
seenIPs := make(map[string]bool) seenIPs := make(map[string]bool)