happyDomain/checker-sdk-go
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

registry: reject checker registration with empty ID

Browse source 
Prevent silent bugs where a CheckerDefinition with an unset ID
would be registered under the empty string key, becoming unfindable
and potentially colliding with other empty-ID registrations.
This commit is contained in:
nemunaire 2026-04-10 16:20:34 +07:00
commit 688d32cc9f
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
checker/registry.go
View file

@ -33,6 +33,10 @@ var observationProviderRegistry = map[ObservationKey]ObservationProvider{}
// always indicates a deployment mistake (two plugins shipping the same // always indicates a deployment mistake (two plugins shipping the same
// checker, or a plugin shadowing a built-in). // checker, or a plugin shadowing a built-in).
func RegisterChecker(c *CheckerDefinition) { func RegisterChecker(c *CheckerDefinition) {
if c.ID == "" {
log.Println("Warning: refusing to register checker with empty ID")
return
}
if _, exists := checkerRegistry[c.ID]; exists { if _, exists := checkerRegistry[c.ID]; exists {
log.Printf("Warning: checker %q is already registered; ignoring duplicate registration", c.ID) log.Printf("Warning: checker %q is already registered; ignoring duplicate registration", c.ID)
return return