Compare commits

..

2 commits

Author SHA1 Message Date
10a65aed02 Move from_address to domain options with no-reply default
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/tag Build is passing
2026-05-21 18:35:48 +08:00
1588131e90 Override is no more needed 2026-05-21 18:17:57 +08:00
2 changed files with 11 additions and 21 deletions

View file

@ -158,7 +158,11 @@ func loadConfig(opts sdk.CheckerOptions) (*runConfig, error) {
return nil, fmt.Errorf("smtp_host is required") return nil, fmt.Errorf("smtp_host is required")
} }
if cfg.FromAddress == "" { if cfg.FromAddress == "" {
return nil, fmt.Errorf("from_address is required") domain := strings.TrimSpace(stringOpt(opts, "domain_name"))
if domain == "" {
return nil, fmt.Errorf("from_address is required when domain_name is not set")
}
cfg.FromAddress = "no-reply@" + strings.TrimSuffix(domain, ".")
} }
parsedFrom, err := mail.ParseAddress(cfg.FromAddress) parsedFrom, err := mail.ParseAddress(cfg.FromAddress)
if err != nil { if err != nil {

View file

@ -35,19 +35,6 @@ func Definition() *sdk.CheckerDefinition {
}, },
}, },
UserOpts: []sdk.CheckerOptionDocumentation{ UserOpts: []sdk.CheckerOptionDocumentation{
{
Id: "happydeliver_url",
Type: "string",
Label: "happyDeliver instance URL (override)",
Description: "Override the operator-provided happyDeliver URL.",
},
{
Id: "happydeliver_token",
Type: "string",
Label: "happyDeliver API token (override)",
Description: "Override the operator-provided happyDeliver token.",
Secret: true,
},
{ {
Id: "smtp_host", Id: "smtp_host",
Type: "string", Type: "string",
@ -84,13 +71,6 @@ func Definition() *sdk.CheckerDefinition {
Choices: []string{"starttls", "tls", "none"}, Choices: []string{"starttls", "tls", "none"},
Default: "starttls", Default: "starttls",
}, },
{
Id: "from_address",
Type: "string",
Label: "From address",
Description: "Address used in the From header of the test email. Must be in the tested domain.",
Required: true,
},
{ {
Id: "subject_override", Id: "subject_override",
Type: "string", Type: "string",
@ -132,6 +112,12 @@ func Definition() *sdk.CheckerDefinition {
Label: "Domain name", Label: "Domain name",
AutoFill: sdk.AutoFillDomainName, AutoFill: sdk.AutoFillDomainName,
}, },
{
Id: "from_address",
Type: "string",
Label: "From address",
Description: "Address used in the From header of the test email. Must be in the tested domain. Defaults to no-reply@<domain>.",
},
}, },
}, },
Rules: []sdk.CheckRule{ Rules: []sdk.CheckRule{