Extract disabledResult and evidenceEval helpers to reduce boilerplate
Add two shared helpers to source.go and apply them across all sources: - disabledResult(id, name) replaces the repeated inline SourceResult literal - evidenceEval(r, severity) replaces the identical Evaluate body in 6 sources
This commit is contained in:
parent
061b5361ca
commit
6b1d2e2540
9 changed files with 28 additions and 34 deletions
|
|
@ -47,7 +47,7 @@ func (*openPhishSource) Options() SourceOptions {
|
|||
|
||||
func (s *openPhishSource) Query(ctx context.Context, domain, registered string, opts sdk.CheckerOptions) []SourceResult {
|
||||
if !sdk.GetBoolOption(opts, "enable_openphish", true) || registered == "" {
|
||||
return []SourceResult{{SourceID: s.ID(), SourceName: s.Name(), Enabled: false}}
|
||||
return disabledResult(s.ID(), s.Name())
|
||||
}
|
||||
|
||||
urls, size, fetched, err := s.cache.lookup(ctx, registered)
|
||||
|
|
@ -70,10 +70,7 @@ func (s *openPhishSource) Query(ctx context.Context, domain, registered string,
|
|||
}
|
||||
|
||||
func (*openPhishSource) Evaluate(r SourceResult) (bool, string) {
|
||||
if r.Enabled && r.Error == "" && len(r.Evidence) > 0 {
|
||||
return true, SeverityCrit
|
||||
}
|
||||
return false, ""
|
||||
return evidenceEval(r, SeverityCrit)
|
||||
}
|
||||
|
||||
func (*openPhishSource) Diagnose(res SourceResult) Diagnosis {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue