From a62e5f1a597ee9ad89daaea4777e38df31322168 Mon Sep 17 00:00:00 2001
From: Pierre-Olivier Mercier <nemunaire@nemunai.re>
Date: Tue, 2 May 2023 20:36:53 +0200
Subject: [PATCH] Introducing UncompleteZoneMeta to solve inconsistent API on
 zone_history

Closes: https://github.com/happyDomain/python-sdk/issues/1
---
 happydomain/api.py    |  2 +-
 happydomain/domain.py |  9 +++++---
 happydomain/zone.py   | 48 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 55 insertions(+), 4 deletions(-)

diff --git a/happydomain/api.py b/happydomain/api.py
index cff195e..c506ebb 100644
--- a/happydomain/api.py
+++ b/happydomain/api.py
@@ -51,7 +51,7 @@ class HappyDomain:
 
         if val is not None:
             for au in val:
-                ret.append(Domain(self, **au))
+                ret.append(Domain(self, zone_history_are_ids=True, **au))
 
         return ret
 
diff --git a/happydomain/domain.py b/happydomain/domain.py
index f146712..5302178 100644
--- a/happydomain/domain.py
+++ b/happydomain/domain.py
@@ -2,11 +2,11 @@ import json
 from urllib.parse import quote
 
 from .error import HappyError
-from .zone import ZoneMeta, Zone
+from .zone import UncompleteZoneMeta, ZoneMeta, Zone
 
 class Domain:
 
-    def __init__(self, _session, id, id_owner, id_provider, domain, zone_history, group=""):
+    def __init__(self, _session, id, id_owner, id_provider, domain, zone_history, zone_history_are_ids=False, group=""):
         self._session = _session
 
         self.id = id
@@ -14,7 +14,10 @@ class Domain:
         self.id_provider = id_provider
         self.domain = domain
         self.group = group
-        self.zone_history = zone_history if zone_history is not None else []
+        if zone_history_are_ids:
+            self.zone_history = [UncompleteZoneMeta(self, zid) for zid in zone_history]
+        else:
+            self.zone_history = zone_history if zone_history is not None else []
 
     def _dumps(self):
         return json.dumps({
diff --git a/happydomain/zone.py b/happydomain/zone.py
index bd8757c..ca3ff77 100644
--- a/happydomain/zone.py
+++ b/happydomain/zone.py
@@ -31,6 +31,54 @@ class ZoneMeta:
         })
 
 
+class UncompleteZoneMeta(ZoneMeta):
+
+    def __init__(self, _domain, id):
+        self._complete = None
+        self._domain = _domain
+        self.id = id
+
+    def resolve(self):
+        if self._complete is None:
+            self._complete = self._domain.get_zone(self.id)
+
+    @property
+    def id_author(self):
+        self.resolve()
+        return self._complete.id_author
+
+    @property
+    def default_ttl(self):
+        self.resolve()
+        return self._complete.default_ttl
+
+    @property
+    def last_modified(self):
+        self.resolve()
+        return self._complete.last_modified
+
+    @property
+    def last_modified(self):
+        self.resolve()
+        return self._complete.last_modified
+
+    @property
+    def commit_message(self):
+        self.resolve()
+        return self._complete.commit_message
+
+    @property
+    def commit_date(self):
+        self.resolve()
+        return self._complete.commit_date
+
+    @property
+    def published(self):
+        self.resolve()
+        return self._complete.published
+
+
+
 class Zone(ZoneMeta):
 
     def __init__(self, _session, _domainid, **kwargs):