From 205d890f32cb586c535b645bf21a239a195ef6f9 Mon Sep 17 00:00:00 2001
From: Pierre-Olivier Mercier <nemunaire@nemunai.re>
Date: Sat, 3 Feb 2024 09:09:41 +0100
Subject: [PATCH] CAA: Improve form usage

---
 ui/src/lib/components/resources/CAA-issuer.svelte | 5 +++--
 ui/src/lib/locales/en.json                        | 1 +
 ui/src/lib/locales/fr.json                        | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/ui/src/lib/components/resources/CAA-issuer.svelte b/ui/src/lib/components/resources/CAA-issuer.svelte
index d6bd546..20f2448 100644
--- a/ui/src/lib/components/resources/CAA-issuer.svelte
+++ b/ui/src/lib/components/resources/CAA-issuer.svelte
@@ -32,6 +32,7 @@
      Input,
  } from '@sveltestrap/sveltestrap';
 
+ import { t } from '$lib/translations';
  import { issuers, rev_issuers } from './CAA-issuers';
 
  const dispatch = createEventDispatcher();
@@ -46,12 +47,12 @@
 </script>
 
 <div class="d-flex gap-2 mb-2">
-    {#if (newone && value.IssuerDomainName == "") || rev_issuers[value.IssuerDomainName]}
+    {#if (newone && value.IssuerDomainName == undefined) || rev_issuers[value.IssuerDomainName]}
         <Input type="select" name="select" id="exampleSelect" readonly={readonly} bind:value={value.IssuerDomainName}>
             {#each Object.keys(issuers) as issuer}
                 <option value={issuers[issuer][0]}>{issuer}</option>
             {/each}
-            <option value={" "}>Autre</option>
+            <option value={""}>{$t('common.other')}</option>
         </Input>
     {:else}
         <Input type="text" bind:value={value.IssuerDomainName} />
diff --git a/ui/src/lib/locales/en.json b/ui/src/lib/locales/en.json
index 346122a..b3bc96e 100644
--- a/ui/src/lib/locales/en.json
+++ b/ui/src/lib/locales/en.json
@@ -44,6 +44,7 @@
         "no-content": "No content",
         "no-thing": "No {{thing}}",
         "new-row": "New row",
+        "other": "Other",
         "password": "Password",
         "previous": "Previous",
         "rename": "Rename",
diff --git a/ui/src/lib/locales/fr.json b/ui/src/lib/locales/fr.json
index 740ef83..5fe8225 100644
--- a/ui/src/lib/locales/fr.json
+++ b/ui/src/lib/locales/fr.json
@@ -40,6 +40,7 @@
         "go": "C'est parti !",
         "name": "Nom",
         "next": "Suivant",
+        "other": "Autre",
         "password": "Mot de passe",
         "previous": "Précédent",
         "rename": "Renommer",