From c11f2403d238a93d294f6fa0d19bcdcf48773b4e Mon Sep 17 00:00:00 2001
From: Pierre-Olivier Mercier <nemunaire@nemunai.re>
Date: Sun, 25 Nov 2018 05:41:46 +0100
Subject: [PATCH] frontend: why so much useless style?

---
 frontend/static/views/defi.html      | 20 ++++++++++----------
 frontend/static/views/rules.html     |  2 +-
 frontend/static/views/team-edit.html |  2 +-
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/frontend/static/views/defi.html b/frontend/static/views/defi.html
index 2ca2c5eb..ec46443d 100644
--- a/frontend/static/views/defi.html
+++ b/frontend/static/views/defi.html
@@ -12,13 +12,13 @@
 	    </ol>
 	  </nav>
 
-	  <div class="alert alert-warning" style="margin-top:15px;" ng-if="!(my.exercices[current_exercice])">
+	  <div class="alert alert-warning mt-3" ng-if="!(my.exercices[current_exercice])">
 	    Vous n'avez pas encore accès à cet exercice.
 	  </div>
-	  <div class="jumbotron text-indent" style="margin-top: 15px" ng-if="!(my.exercices[current_exercice])">
+	  <div class="jumbotron text-indent mt-3" ng-if="!(my.exercices[current_exercice])">
 	    <p class="lead text-justify" ng-bind-html="themes[current_theme].intro"></p>
 	  </div>
-	  <div class="jumbotron text-indent" style="margin-top: 15px" ng-if="(my.exercices[current_exercice])">
+	  <div class="jumbotron text-indent mt-3" ng-if="(my.exercices[current_exercice])">
 	    <h3 class="display-4">{{ themes[current_theme].exercices[current_exercice].title }}</h3>
 	    <a ng-href="/tags/{{tag}}" class="badge badge-pill badge-secondary mr-2 mb-2" ng-repeat="tag in themes[current_theme].exercices[current_exercice].tags">#{{ tag }}</a>
 	    <p class="lead text-justify" ng-bind-html="my.exercices[current_exercice].statement"></p>
@@ -32,8 +32,8 @@
 
       <div class="row">
 
-	<div class="col-xl" ng-if="(my.exercices[current_exercice] && my.exercices[current_exercice].files.length)" style="margin-bottom: 15px">
-	  <div class="card" style="margin-bottom: 15px">
+	<div class="col-xl mb-5" ng-if="(my.exercices[current_exercice] && my.exercices[current_exercice].files.length)">
+	  <div class="card">
 	    <div class="card-header text-white">
 	      <span class="glyphicon glyphicon-download-alt" aria-hidden="true"></span> Téléchargements
 	    </div>
@@ -47,8 +47,8 @@
 	  </div>
 	</div>
 
-	<div class="col-xl" ng-if="(my.exercices[current_exercice] && my.exercices[current_exercice].hints.length)" style="margin-bottom: 15px">
-	  <div class="card border-info" style="margin-bottom: 15px">
+	<div class="col-xl mb-5" ng-if="(my.exercices[current_exercice] && my.exercices[current_exercice].hints.length)">
+	  <div class="card border-info">
 	    <div class="card-header bg-info text-white">
 	      <span class="glyphicon glyphicon-lamp" aria-hidden="true"></span> Indices
 	    </div>
@@ -66,8 +66,8 @@
 	  </div>
 	</div>
 
-	<div class="col-xl" style="margin-bottom: 25px">
-	  <div class="card border-danger" ng-if="my.team_id && my.exercices[current_exercice] && !(my.exercices[current_exercice].solved)" style="margin-bottom: 15px">
+	<div class="col-xl mb-5">
+	  <div class="card border-danger" ng-if="my.team_id && my.exercices[current_exercice] && !(my.exercices[current_exercice].solved)">
 	    <div class="card-header bg-danger text-white">
 	      <span class="glyphicon glyphicon-flag" aria-hidden="true"></span> Faire son rapport
 	    </div>
@@ -86,7 +86,7 @@
 
 		<div class="form-check" ng-repeat="(k,mcq) in mcqs">
 		  <p ng-if="mcq.title" ng-bind="mcq.title"></p>
-		  <div class="custom-control custom-checkbox" ng-repeat="(cid,choice) in mcq.choices" style="display: block">
+		  <div class="custom-control custom-checkbox" ng-repeat="(cid,choice) in mcq.choices">
 		    <input class="custom-control-input" type="checkbox" id="mcq_{{k}}_{{cid}}" name="mcq_{{k}}_{{cid}}" ng-model="choice.value">
 		    <label class="custom-control-label" for="mcq_{{k}}_{{cid}}" ng-bind="choice.label"></label>
 		  </div>
diff --git a/frontend/static/views/rules.html b/frontend/static/views/rules.html
index 9d1d568c..847bb742 100644
--- a/frontend/static/views/rules.html
+++ b/frontend/static/views/rules.html
@@ -1,4 +1,4 @@
-<div class="card-group text-justify" style="margin-bottom: 25px;">
+<div class="card-group text-justify mb-5">
 <div class="card">
 <div class="card-body text-indent">
   <h2>Débloquage des challenges</h2>
diff --git a/frontend/static/views/team-edit.html b/frontend/static/views/team-edit.html
index 31f51566..979a8109 100644
--- a/frontend/static/views/team-edit.html
+++ b/frontend/static/views/team-edit.html
@@ -13,7 +13,7 @@
   </ul>
 </div>
 
-<div class="card border-info" style="margin-top: 10px">
+<div class="card border-info mt-3">
   <div class="card-header bg-info text-light">Changer de nom d'équipe</div>
   <div class="card-body">
     <p ng-class="messageClass" ng-if="message || sberr"><strong ng-if="!sberr">Votre demande a bien été envoyée !</strong><strong ng-if="sberr">{{ sberr }}</strong> {{ message }}</p>