From 86d9a039c8b15af331a9f6355200a6b589cc53a2 Mon Sep 17 00:00:00 2001 From: Pierre-Olivier Mercier Date: Tue, 12 Jul 2022 12:03:54 +0200 Subject: [PATCH] epita-rules: Requires placeholder for each flag --- repochecker/epita/flags.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/repochecker/epita/flags.go b/repochecker/epita/flags.go index 0c76289c..070d7b7d 100644 --- a/repochecker/epita/flags.go +++ b/repochecker/epita/flags.go @@ -23,6 +23,10 @@ func EPITACheckKeyFlag(flag *fic.FlagKey, raw string) (errs []error) { errs = append(errs, fmt.Errorf("CVE numbers are required to be UCQ with choice_cost")) } + if flag.Placeholder == "" && (flag.Type == "text" || (flag.Type == "ucq" && flag.ChoicesCost > 0)) { + errs = append(errs, fmt.Errorf("no placeholder defined")) + } + return }